From cfcb8b0febe4eb35ca3eb1530441857d1265fcb4 Mon Sep 17 00:00:00 2001 From: "Harish.K" Date: Fri, 6 May 2016 18:58:48 +0530 Subject: [PATCH] Fix: exporting env ENABLE_NPM_FAILOVER=false will not work unless we parse the string --- app.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app.js b/app.js index fd6da09..8ff1606 100644 --- a/app.js +++ b/app.js @@ -39,7 +39,8 @@ app.get( '/:package', function( req, res, next ){ .tap( function( isExists ){ if( !isExists ){ if ( !ENABLE_NPM_FAILOVER ) { - return Promise.reject( { status:404, message: 'Package not found' }); + res._log.cacheHit = '!!!'; + return Promise.reject( { status:404, message: {}}); } res._log.cacheHit = '---'; return fetchAndCacheMetadata( packageName, cacheFile ); @@ -66,7 +67,8 @@ app.get( '/:package/-/:tarball', function( req, res, next ){ .tap( function( isExists ){ if( !isExists ){ if ( !ENABLE_NPM_FAILOVER ) { - return Promise.reject( { status: 404, message: '' }); + res._log.cacheHit = '!!!'; + return Promise.reject( { status: 404, message: {} }); } res._log.cacheHit = '---'; return fetchAndCacheTarball( packageName, version, packagePath ); @@ -90,7 +92,7 @@ app.use(function(req, res, next) { // error handlers app.use(function(err, req, res, next) { - console.log( err.stack ); + err.stack && console.log( err.stack ); res.status(err.status || 500); res.send( err.message || err ); if( next ) { next(); }